fix impure tests

pkgs/clan-cli/tests/sshd.py

@@ -59,6 +59,7 @@ def sshd_config(project_root: Path, test_root: Path) -> Iterator[SshdConfig]:
         MaxStartups 64:30:256
         AuthorizedKeysFile {host_key}.pub
         AcceptEnv REALPATH
+        PasswordAuthentication no
         """
         )
         login_shell = dir / "shell"
@@ -109,7 +110,6 @@ def sshd(
 ) -> Iterator[Sshd]:
     import subprocess
 
-    subprocess.run(["echo", "hello"], check=True)
     port = unused_tcp_port()
     sshd = shutil.which("sshd")
     assert sshd is not None, "no sshd binary found"
@@ -123,6 +123,7 @@ def sshd(
     )
 
     while True:
+        print(sshd_config.path)
         if (
             subprocess.run(
                 [
@@ -137,7 +138,7 @@ def sshd(
                     "-p",
                     str(port),
                     "true",
-                ]
+                ],
             ).returncode
             == 0
         ):

pkgs/clan-cli/tests/test_flake_with_core/flake.nix

@@ -5,25 +5,29 @@
   # this placeholder is replaced by the path to nixpkgs
   inputs.clan-core.url = "__CLAN_CORE__";
 
-  outputs = { self, clan-core }: {
-    nixosConfigurations = clan-core.lib.buildClan {
-      directory = self;
-      machines = {
-        vm1 = { modulesPath, ... }: {
-          imports = [ "${toString modulesPath}/virtualisation/qemu-vm.nix" ];
-          clan.networking.deploymentAddress = "__CLAN_DEPLOYMENT_ADDRESS__";
-          sops.age.keyFile = "__CLAN_SOPS_KEY_PATH__";
+  outputs = { self, clan-core }:
+    let
+      clan = clan-core.lib.buildClan {
+        directory = self;
+        machines = {
+          vm1 = { modulesPath, ... }: {
+            imports = [ "${toString modulesPath}/virtualisation/qemu-vm.nix" ];
+            clan.networking.deploymentAddress = "__CLAN_DEPLOYMENT_ADDRESS__";
+            sops.age.keyFile = "__CLAN_SOPS_KEY_PATH__";
 
-          clanCore.secrets.testpassword = {
-            generator = ''
-              echo "secret1" > "$secrets/secret1"
-              echo "fact1" > "$facts/fact1"
-            '';
-            secrets.secret1 = { };
-            facts.fact1 = { };
+            clanCore.secrets.testpassword = {
+              generator = ''
+                echo "secret1" > "$secrets/secret1"
+                echo "fact1" > "$facts/fact1"
+              '';
+              secrets.secret1 = { };
+              facts.fact1 = { };
+            };
           };
         };
       };
+    in
+    {
+      inherit (clan) nixosConfigurations clanInternals;
     };
-  };
 }

pkgs/clan-cli/tests/test_secrets_upload.py

@@ -11,7 +11,7 @@ if TYPE_CHECKING:
 
 
 @pytest.mark.impure
-def test_upload_secret(
+def test_secrets_upload(
     monkeypatch: pytest.MonkeyPatch,
     test_flake_with_core: Path,
     host_group: HostGroup,